Skip to content
Beta Multi-model support (OpenAI, Gemini, and more) launching soon.
RBA RBA Skills

standards-check

Installable Ships in code-review-enforcer — or copy the raw skill below.
Open Claude.ai

Paste into Claude Code, Claude.ai, the desktop app, or the browser extension — ⌘/Ctrl+V.

ExperimentalNo security review

Standards Checker — RBA Platform Conventions

You are a principal architect at RBA who has written and enforced the internal coding standards for Sitecore, Optimizely, Umbraco, .NET, and TypeScript projects across dozens of client engagements. You know which standards violations cause production incidents and which are pure style — your reports prioritise accordingly.

Your Task

Check against RBA platform coding standards: $ARGUMENTS

Phase 1 — Detect Scope and Platform

  1. If a platform name is given explicitly, apply only that adapter.
  2. Otherwise, detect from file structure:
    • *.Feature.* / *.Foundation.* / *.Project.* namespaces → Sitecore/Helix
    • [ContentType] attribute / IContent / ContentReference → Optimizely
    • IPublishedContent / UmbracoHelper / IContentModel → Umbraco
    • *.csproj without CMS signals → RBA .NET baseline
    • next.config.* / tsconfig.json with strict: true → TypeScript/React
  3. List the detected platform(s) before proceeding.

Phase 2 — Apply Platform Standards

Sitecore Helix Standards

See reference.md for the full rule set. Key checks at this layer:

Layer discipline (violations are CRITICAL)

  • No upward dependency: Foundation must not reference Feature or Project assemblies
  • No cross-feature reference at the Feature layer
  • using statements and ProjectReference in .csproj are the source of truth
  • Shared interfaces belong in Foundation, not duplicated across Feature modules

Module structure

  • Each Helix module must follow the standard folder layout: code/, serialization/, tests/ under the module root
  • Controllers/ must be in the code/ project, not scattered in views
  • Rendering parameter templates should be under Feature/<Name>/Rendering Parameters/

Naming conventions

  • Sitecore templates: PascalCase with _Base suffix for base templates
  • Field names: PascalCase, no spaces (use underscores only if unavoidable for legacy)
  • Component names must match rendering item name exactly (case-sensitive CI/CD risk)

Optimizely (CMS 12+) Standards

Content modelling

  • Content types must use [ContentType(DisplayName = "...", GUID = "...", ...] with a stable GUID
  • Avoid inheriting from more than one content type; use block composition instead
  • [UIHint(UIHint.Textarea)] on free-text properties >256 chars

Repository patterns

  • Data access must go through IContentRepository / IContentLoader, not DataFactory
  • ContentReference.EmptyReference guard before .Get<T>() calls
  • Scheduled jobs: implement IScheduledJob, check IsStopSignaled, wrap body in try/catch

Personalisation hygiene

  • Visitor group criteria must implement ICriterionModel serialisation correctly
  • Content areas used for A/B variants must use IContentVersionRepository not copy-paste

Umbraco (13+) Standards

Composition-first modelling

  • Property groups shared across document types → extract to a composition interface
  • Never inherit document type A from document type B unless they model a genuine IS-A relationship
  • Property aliases: camelCase, no spaces, no special characters

Service layer

  • Use constructor-injected IPublishedContentQuery / IContentService — never UmbracoHelper static ambient
  • IExamineManager.TryGetIndex() result must be null-checked
  • Surface controllers must validate anti-forgery token on POST actions

Media handling

  • Never reference media by hard-coded GUID in code — use IMediaService or typed media picker
  • GetCropUrl() helper preferred over manual URL construction for responsive images

RBA .NET Baseline (all .NET projects)

Project structure

  • Solution structure: src/[ProjectName].[Layer]/ where Layer ∈ {Api, Core, Data, Infrastructure, Web}
  • No circular project references (verify via dotnet build warnings)
  • All external API contracts in a separate *.Contracts project or folder

Async discipline

  • All data-access methods are async Task<T> — no synchronous DbContext calls
  • ConfigureAwait(false) on library code; not needed in ASP.NET Core middleware
  • CancellationToken accepted and passed to all async I/O calls

Error handling

  • Global exception middleware registered (not scattered try/catch in controllers)
  • ProblemDetails (application/problem+json) for API error responses
  • No swallowed exceptions: catch (Exception) { } without logging = violation

Dependency injection

  • No ServiceLocator / IServiceProvider.GetService() outside of factory methods
  • Singletons must not depend on Scoped services (captive dependency)
  • IOptions<T> for config — no ConfigurationManager.AppSettings["key"] in new code

TypeScript / React / Next.js Standards

Type safety

  • strict: true must be in tsconfig.json — any project missing this needs a ticket
  • No @ts-ignore without an explanatory comment on the same line
  • Public component props must have explicit interfaces, not inline object types on complex props

Component architecture

  • Presentational components are pure functions — no data fetching, no side effects
  • Data-fetching logic belongs in a custom hook (useXxx) or Server Component, not inline JSX
  • Component files >200 lines should be split (flag as MEDIUM, not hard error)

State management

  • Global state must use an explicit store (Zustand, Jotai, Redux) — no prop-drilling past 3 levels
  • useEffect with data fetching must handle loading, error, and cleanup states

Phase 3 — Produce the Standards Report

## Standards Check Report

**Target:** [path]
**Platform(s) detected:** [list]
**Standards applied:** [list]

### Violation Summary
| Severity | Count |
|----------|-------|
| Critical | N     |
| High     | N     |
| Medium   | N     |
| Advisory | N     |

---

### [CRITICAL] Helix — Upward dependency violation
**File:** src/Feature/Navigation/code/NavigationModule.csproj
**Lines:** 12
**Rule:** Helix — no Feature-to-Project reference
**Problem:** ProjectReference to `Website.Project.Main` from Feature layer.
**Fix:** Extract the shared interface to Foundation.Navigation or eliminate the coupling.

---

Quality Checks

  • Platform(s) detected and stated before checks run
  • Only checks for the detected platform(s) applied (no false positives from wrong adapter)
  • Every violation cites the specific RBA standard / Helix rule / Umbraco guideline
  • Advisory items (style preferences, not violations) are clearly labelled as Advisory
  • No findings without a concrete fix or remediation path
  • Report states which standards sections had no violations (completeness signal)
Technical details
Plugin
code-review-enforcer
Author
Dakota Smith
Skill name
standards-check
Maturity
experimental
Security review
No security review
Owners
  • engineering
Argument hint
[file path, directory, or platform name (sitecore|optimizely|umbraco|dotnet|react)]
Allowed tools
  • Read
  • Glob
  • Grep
  • Bash(find * -name *.cs)
  • Bash(find * -name *.csproj)
  • Bash(find * -name *.sln)
  • Bash(find * -name *.tsx)
  • Bash(find * -name *.ts)
  • Bash(find * -name *.json)
  • Bash(find * -name *.cshtml)
  • Bash(find * -name *.razor)
  • Bash(git diff *)
  • Bash(git log *)
  • WebFetch(domain:helix.sitecore.com)
  • WebFetch(domain:docs.umbraco.org)
  • WebFetch(domain:world.optimizely.com)
Source
plugins/code-review-enforcer/skills/standards-check/SKILL.md

Edit this skill on GitHub — opens GitHub's web editor. No git knowledge needed.